Add CreateSchemaWithIDAndVersion() to the sr package
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
reviewed
Nov 11, 2024
pkg/sr/api.go
Outdated
| return SubjectSchema{}, err | ||
| } | ||
| } else { | ||
| if err := cl.post(ctx, path, SubjectSchema{Schema: s, ID: id}, &into); err != nil { |
There was a problem hiding this comment.
Is this a RP specific thing, or the API in general?
There was a problem hiding this comment.
I found it in the Confluent docs here: https://docs.confluent.io/platform/current/schema-registry/installation/migrate.html#migrate-individual-schemas. See how they POST the schema ID. It’s not mentioned in the API reference though…
Signed-off-by: Mihai Todor <[email protected]>
mihaitodor
force-pushed
the
add-create-schema--with-fixed-id
branch
from
af3fea9 to
143aeab
Compare
mihaitodor
changed the title
CreateSchemaWithID() to the sr packageCreateSchemaWithIDAndVersion() to the sr package
|
As per the Slack chat, I updated this new API to include the version ID and set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would come in handy when someone is trying to migrate schemas between two Schema Registry instances and they wish to retain the original IDs to avoid schema ID translation when migrating Kafka messages.