This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Add team register #1029
Open
Add team register #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just like I said in the old PR, this isn't something I really want in Cardinal, because it directly ties it to OCN. |
|
@twizmwazin I think there should be a way to abstract the team authenticator, where you give it a url, and a regex to find the player, if you want it to be searching in ocn, it would be "https://oc.tc/teams/%team%" and search for the regex "avatar.oc.tc/%uuid%" |
Pablete1234
force-pushed
the
tmregister
branch
6 times, most recently
from
18229a1 to
8296b11
Compare
Pablete1234
force-pushed
the
tmregister
branch
from
8296b11 to
88af870
Compare
Pablete1234
force-pushed
the
tmregister
branch
from
88af870 to
74f5a3c
Compare
Pablete1234
force-pushed
the
tmregister
branch
from
74f5a3c to
8ed2808
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old team register was completly broken by the name to UUID change, this one fixes therse issues.
PS: this is still by far not a perfect module, and i would like to rewrite parts of it