Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and improved seeds #8695
base: main
Are you sure you want to change the base?
Refactored and improved seeds #8695
Changes from all commits
5077f95
9bfd3aa
afa0c9c
50c3df5
047f44a
dad62c4
5c8b606
6c3426c
253da19
4bfbb0b
214d0d8
8ae3386
3fce159
1247412
61ed304
61ef4eb
c4e121a
a29acc0
b1433d0
894a794
378e390
4fc18fb
7bfcb47
59a48b2
1f53d0f
7da7f1a
5d9afc2
4a210bc
59478a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: hook uses FieldContext but doesn't handle case where context is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: parseJson could return undefined/null - need to handle this case explicitly to avoid runtime errors when using fieldValueParsed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Schema only allows null or string, but rich text content is typically stored as JSON string of PartialBlock[] based on usage in useRichTextField.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The RichText example value should be an object, not a string. This will cause type errors with FieldRichTextValue. Keep it as
{ key: 'value' }
without quotes.