Drop redundant g] and g[ mappings #39
Conversation
| @@ -54,16 +54,12 @@ function! s:enable(...) | |||
|
|
|||
| if !empty(g:braceless#key#jump_prev) | |||
| execute 'map <buffer> ['.g:braceless#key#jump_prev.' <Plug>(braceless-jump-prev-n)' | |||
| execute 'map <buffer> g'.g:braceless#key#jump_prev.' <Plug>(braceless-jump-prev-n-indent)' | |||
There was a problem hiding this comment.
Could you turn this into an option that's disabled by default instead? There might be people who want to retain this feature and I don't want to blindside anyone without an option to get it back.
There was a problem hiding this comment.
I thought about this quite a bit and I honestly think it should just be dropped.
If anyone misses it they can always remap it and g] was never documented as the primary key binding.
That being said I'll do as you wish.
| *g]* Move forward to an increased indent level | ||
| *g[* Move backward to a decreased indent level | ||
| By default you can move between block heads using the |[[| and |]]| motions. | ||
| This fits better with VIM's traditional notion of a |section|. |
There was a problem hiding this comment.
This could read:
By default you can move between block heads using the |[[| and |]]| motions.
This fits better with VIM's traditional notion of a |section|. If you want
motions for moving between block indent levels ... etc
There was a problem hiding this comment.
So you want that trailing off at the end or are you expecting me to fill that in?
There was a problem hiding this comment.
Oh and I'm assuming for now you want the new option documented as well?
There was a problem hiding this comment.
Yeah just fill it in. I guess a boolean variable like braceless_jump_indent would be good. I'll leave it to your best judgement on how to word the doc text.
The use of `g]` masks the standard mapping for `:tselect`. Disable the indent jumping feature by default. Indicate how to re-enable it in the docs. Fixes tweekmonster#37
|
@tweekmonster hopefully that's closer to what you want. |
|
@tgoodlet Yes it is! Sorry I didn't reply sooner. I became ill on Friday and didn't want to make comments that my healthy self wouldn't agree with. To elaborate on why I want to retain this as an option: you mentioned that it's redundant, but it's not. The project I was working on had complex Though, it still might be nicer to have |
|
@tweekmonster no worries I just got the requested changes pushed this afternoon. Yes, I realized after looking more thoroughly at the source that I was wrong about saying it was "redundant* (didn't notice the Yeah I for sure like the idea of separate controls for |
These motions are redundant (since [[ and ]] are already used) and
also mask other standard mappings (eg. g] normally is shorthand for
:tselect). Adjust the docs to match.
Fixes #37