Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make source positions in logs 1-based for consistency #664

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Make source positions in logs 1-based for consistency #664

merged 1 commit into from
Dec 21, 2023

Conversation

evertedsphere
Copy link
Contributor

Changes logs to use 1-based source positions by adding a NodeExt trait and a Display impl to LocalQueryMatch.

Closes #548, unless I've missed something.

Xophmeister
Xophmeister approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@evertedsphere evertedsphere merged commit 4d48c23 into main Dec 21, 2023
2 of 4 checks passed
@evertedsphere evertedsphere deleted the es/one-based-logs branch December 21, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xophmeister Xophmeister Xophmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error messages use 1-based position, but logs use 0-based.
2 participants
@evertedsphere @Xophmeister