-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor extraction and caching of CabalInfo #1034
base: master
Are you sure you want to change the base?
Conversation
I'm happy with the first commit, which I adjusted a bit to apply the new helper to both caching of cabal files and |
Ah sure, I could make the changes backwards compatible. Give me a second |
da1c023
to
c0bf761
Compare
@mrkkrp how's that? Also, there's a weeder failure. Maybe |
c0bf761
to
d589b1d
Compare
Eh, I like splitting the code in two branches (old and new) even less. Let's apply d91bbd0 and keep the rest on the shelf for a while until we decide to release 0.8.0.0 at which point we can make a clean break. |
Sure up to you |
d589b1d
to
d575601
Compare
Broken off from #1033
This change has the following improvements:
CabalInfo
return all info for the cabal file, without reference to the source fileparseCabalInfo
as just "parse cabal file", not "parse cabal file + extract info relevant to given source file"