Backport nls crash fix #2127
Closed
Backport nls crash fix #2127
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm that this fixes the issue on my hand, thanks! I think we don't need to merge that in fact. The update script takes care of creating the |
|
Bencher Report| Branch | nls-crash-backport |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot | 490,090.00 |
| foldl arrays 50 | 📈 view plot | 1,682,500.00 |
| foldl arrays 500 | 📈 view plot | 6,664,900.00 |
| foldr strings 50 | 📈 view plot | 6,986,000.00 |
| foldr strings 500 | 📈 view plot | 61,264,000.00 |
| generate normal 250 | 📈 view plot | 45,547,000.00 |
| generate normal 50 | 📈 view plot | 1,937,600.00 |
| generate normal unchecked 1000 | 📈 view plot | 3,295,200.00 |
| generate normal unchecked 200 | 📈 view plot | 762,790.00 |
| pidigits 100 | 📈 view plot | 3,176,800.00 |
| pipe normal 20 | 📈 view plot | 1,494,000.00 |
| pipe normal 200 | 📈 view plot | 9,850,600.00 |
| product 30 | 📈 view plot | 824,990.00 |
| scalar 10 | 📈 view plot | 1,494,600.00 |
| sum 30 | 📈 view plot | 812,790.00 |
|
It's been released, so we can close this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case this is the cause of #2125 here's a backport of the fix. I can't actually reproduce the exact issue, but it sounds like the same problem (especially the part about how it doesn't trigger if you copy-paste, because the issue is caused by a stale cache and so it might not get hit if you enter the input all at once). Also, I did double-check that the files refactor was in 1.9.0 but the warnings PR (which originally contained this fix) wasn't.
Probably targeting the 1.9.0-release branch isn't quite right; I guess we should branch out a 1.9.1-release first?