Do deep eval for doctests

[jneem]

Previously, we weren't doing deep eval of doctests, which would fail to catch some errors.

I think maybe there are use-cases where you don't want full evaluation, but I'm pretty sure it should be the default. (And then we could support a test annotation to make it lazy if anyone actually needs that)

[github-actions]

Bencher Report

Branch	doctest-deep-eq
Testbed	ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
fibonacci 10	📈 view plot 🚷 view threshold	495.85
foldl arrays 50	📈 view plot 🚷 view threshold	1,716.40
foldl arrays 500	📈 view plot 🚷 view threshold	7,142.90
foldr strings 50	📈 view plot 🚷 view threshold	6,917.80
foldr strings 500	📈 view plot 🚷 view threshold	60,116.00
generate normal 250	📈 view plot 🚷 view threshold	41,121.00
generate normal 50	📈 view plot 🚷 view threshold	2,081.30
generate normal unchecked 1000	📈 view plot 🚷 view threshold	3,230.60
generate normal unchecked 200	📈 view plot 🚷 view threshold	751.70
pidigits 100	📈 view plot 🚷 view threshold	3,190.40
pipe normal 20	📈 view plot 🚷 view threshold	1,510.40
pipe normal 200	📈 view plot 🚷 view threshold	9,827.50
product 30	📈 view plot 🚷 view threshold	843.86
scalar 10	📈 view plot 🚷 view threshold	1,544.60
sum 30	📈 view plot 🚷 view threshold	825.22

🐰 View full continuous benchmarking report in Bencher

[jneem]

There's still one failing test in the stdlib, which I think is due to the unimplemented record freezing:

std.record.update "bar" 1 {foo = bar + 1, bar | default = 0 }

returns { foo = 1, bar = 1 }, but if I add an Equal contract then:

(std.record.update "bar" 1 {foo = bar + 1, bar | default = 0 }) | std.contract.Equal { foo = 1, bar = 1 }

gives

error: contract broken by a value
  ┌─ <unknown> (generated by evaluation):1:1
  │
1 │ std.contract.Equal { bar = 1, foo = 1, }
  │ ---------------------------------------- expected type
  │
  ┌─ /home/jneeman/tweag/nickel-doctest-deep-eq/core/stdlib/std.ncl:1:34
  │
1 │ std.record.update "bar" 1 {foo = bar + 1, bar | default = 0 }
  │                                  ^^^^^^^ applied to this expression
  │
  ┌─ <unknown> (generated by evaluation):1:1
  │
1 │ 2
  │ - evaluated to this value

[yannham]

Ah. Maybe it's a sign that it's time to implement freezing properly 😅 I can try to take a look at that after the ongoing PR that I have (a simple cleaning of the AstAlloc interface)

[jneem]

It works!