This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Refactor gcSections to resolve symbols first and gc after #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkaracha
force-pushed
the
gkaracha/wip-refactor-gcsections
branch
from
34075fa to
8e7b63c
Compare
gkaracha
force-pushed
the
gkaracha/wip-refactor-gcsections
branch
from
8e7b63c to
0058caa
Compare
TerrorJack
suggested changes
Jul 8, 2020
TerrorJack
approved these changes
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to partition
gcSectionsinto two separate phases without problems (all tests must pass and there should be no performance regressions) is a great step in the right direction. If this PR works as expected, we shall edit the second phase (module filtering/creation from disk) afterwards in a separate PR, instead of doing all at once (PR #666).