Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Implement __hscore_ftruncate #657

Merged
merged 1 commit into from
May 19, 2020
Merged

Implement __hscore_ftruncate #657

merged 1 commit into from
May 19, 2020

Conversation

TerrorJack
Copy link
Member

Closes #655.

@TerrorJack TerrorJack added P1 critical: next release type: bug labels May 19, 2020
@TerrorJack TerrorJack requested a review from gkaracha May 19, 2020 12:20
@TerrorJack TerrorJack self-assigned this May 19, 2020
@TerrorJack
Copy link
Member Author

@gkaracha Do we have other missing posix functions in #640 test cases? Would be better to implement all of those in this PR.

@gkaracha
Copy link
Member

@gkaracha Do we have other missing posix functions in #640 test cases? Would be better to implement all of those in this PR.

The only three cases that I found to barf in #640 due to missing implementations are #653, #654, and #655. If your implementation of __hscore_ftruncate is enough to close #655, then we should be OK. Lemme give it a shot.

@gkaracha
Copy link
Member

@TerrorJack OK, so I tried it out and your patch already fixes #655 👍 The only remaining nofib failure due to missing implementations that I can currently see is #654 and that is for malloc so once buildkite finishes I'd say this one is good to go.

@TerrorJack TerrorJack merged commit 4ebec81 into master May 19, 2020
@TerrorJack TerrorJack deleted the wip-more-posix branch May 19, 2020 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkaracha gkaracha gkaracha approved these changes

Assignees

@TerrorJack TerrorJack

Labels
P1 critical: next release type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of __hscore_ftruncate is missing
2 participants
@TerrorJack @gkaracha