This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
[WIP] NFData Instance for AsteriusModule #624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears we have some trouble already, because FastString and IntMap do not have Generic instances (FastString does not even have an NFData instance) so this cannot work well with Generic. I think we'll end up writing TH by hand for this; we'll see.
Currently ticks seem to go slightly down: < total time = 9.94 secs (9943 ticks @ 1000 us, 1 processor)
< total alloc = 111,163,851,456 bytes (excludes profiling overheads)
---
> total time = 9.39 secs (9389 ticks @ 1000 us, 1 processor)
> total alloc = 111,165,996,664 bytes (excludes profiling overheads)
< total time = 45.82 secs (45824 ticks @ 1000 us, 1 processor)
< total alloc = 3,321,046,968 bytes (excludes profiling overheads)
---
> total time = 45.49 secs (45491 ticks @ 1000 us, 1 processor)
> total alloc = 3,321,054,200 bytes (excludes profiling overheads)
< total time = 0.28 secs (282 ticks @ 1000 us, 1 processor)
< total alloc = 132,290,048 bytes (excludes profiling overheads)
---
> total time = 0.25 secs (249 ticks @ 1000 us, 1 processor)
> total alloc = 132,291,976 bytes (excludes profiling overheads) |
TerrorJack
suggested changes
Apr 28, 2020
TerrorJack
suggested changes
Apr 28, 2020
TerrorJack
suggested changes
Apr 28, 2020
TerrorJack
approved these changes
Apr 28, 2020
Since we are monitoring performance more closely these days, here is a quick comparison:
|
The small cost in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFData
instances for most datatypes inAsterius.Types
, andNFData
instances to fully evaluate the shrinkedAsteriusModule
produced byAsterius.Resolve.linkStart
.After this PR is merged, we should be able to do a little better, by parallelizing
AsteriusModule
s evaluation (see #621).