Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler tooltip initialization #40959

Closed
wants to merge 2 commits into from
Closed

Conversation

fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Oct 19, 2024

Description

Simpler way to initialize tooltips

Motivation & Context

This is boilerplate code I use on every page everywhere. A little golfing may be in order :-)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

n/a


Previously we were targeting browsers that do not support `NodeList.prototype.forEach.

Now all our supported browsers do. Source: https://caniuse.com/mdn-api_nodelist_foreach

@fulldecent
Copy link
Contributor Author

@XhmikosR thanks for the review. Any notes? Anything I can fix?

@fulldecent
Copy link
Contributor Author

Hi @XhmikosR any notes here please?

@julien-deramond
Copy link
Member

I can't speak for XhmikosR's decision to close this PR, but I can offer some arguments on why I would have raised at least concerns:

  1. While support isn't an issue, as you noted, the original approach is probably more educational. It breaks the process into distinct steps: first, obtaining the trigger list, and then initializing the instances. This separation provides a clearer understanding of what's happening at each stage. It also allows more flexibility—for example, someone might want to target a specific element or subset of triggers later.
  2. More importantly, this change would affect consistency across the documentation. The same initialization pattern is used in multiple places. If we were to update it, we'd need to ensure the change is applied everywhere for uniformity. Introducing different approaches within the same documentation could lead to confusion for users who rely on consistent examples.

I hope this helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants