Added object position for images #39930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for submitting a PR, @IarinaX!
As mentioned in this comment, we haven't yet discussed the addition of this feature to Bootstrap.
As we aren't sure that we will embed this feature, and because I respect your time and effort (I don't want you to work for nothing), I'll be closing this PR for now due to some lint issues and the need for additional documentation.
If we decide to move forward with this feature, I'll be sure to reopen this PR so we can pick up from where we left off.
Thanks again for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation & Context
Type of changes
This pull request addresses the issue #39196 by introducing support for the object-position property within Bootstrap's utility classes. The absence of this property limited developers' ability to precisely control the positioning of images within their projects. To remedy this, we have implemented a set of utility classes that enable developers to specify the position of images with greater flexibility and granularity.
Changes:
Added new utility classes for object-position property.
Defined utility classes for centering, top-left, top-right, top-center, bottom-left, bottom-right, and bottom-center positioning options.
Ensured compatibility with Bootstrap's design principles and naming conventions.
Testing:
Conducted thorough testing to verify the functionality and compatibility of the new utility classes across different browsers and devices.
Tested various positioning scenarios to ensure consistent behavior and visual presentation.
Impact:
Enhances the flexibility and usability of Bootstrap's image handling capabilities.
Empowers developers to create visually appealing and well-structured layouts with ease.
Improves the overall user experience for developers working with Bootstrap-based projects.
npm run lint)Live previews
Related issues
Closes #39196