Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: preload page thumbnail if set #39769

Closed
wants to merge 6 commits into from
Closed

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 10, 2024

Note that it expects the normal non-2x image in the front matter and a 2x image must be present too.

Previews:


The real gain might not be noticeable in the previews, because Netlify doesn't cache aggressively the assets like Cloudflare does. But on production, the difference should be noticeable.

This along with #39768 and #39824 should make these pages load significantly faster.

TODO:

  • Adapt social partial to use 2x image if present

Note that it expects the normal non-2x image in the front matter
and a 2x image must be present too.
@XhmikosR XhmikosR added the docs label Mar 10, 2024
@XhmikosR XhmikosR marked this pull request as ready for review March 20, 2024 07:07
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 22, 2024

BTW we should probably resize these images because right now we have them in dimensions that we never reach.

Something like 1600x800 for 2x should suffice.

EDIT: made #39824
EDIT2: converted to draft until the other 2 PRs are merged

@XhmikosR XhmikosR marked this pull request as draft March 22, 2024 14:43
@XhmikosR XhmikosR closed this Apr 1, 2024
@XhmikosR XhmikosR deleted the xmr/docs-preload-img branch April 1, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant