Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buffers from hline and vline (fixes #40) #41

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Remove buffers from hline and vline (fixes #40) #41

merged 3 commits into from
Mar 11, 2023

Conversation

tuupola
Copy link
Owner

@tuupola tuupola commented Mar 11, 2023 •
edited
Loading

See also: tuupola/hagl#44

@tuupola
Copy link
Owner Author

tuupola commented Mar 11, 2023 •
edited
Loading

Before:

[main] 250504 total heap 
[main] 250504 free heap 
[HAGL HAL] Initialising single buffered display.
[HAGL HAL] Initialising SPI.
[HAGL HAL] Baudrate is set to 62500000.
[HAGL HAL] clk_peri 125000000.
[HAGL HAL] clk_sys 125000000.
[HAGL HAL] Inverting display.
[main] 250392 free heap 
[main] 50229 VERTICAL LINES per second, 250080 free heap
[main] 63525 HORIZONTAL LINES per second, 250080 free heap

After:

[main] 250952 total heap 
[main] 250952 free heap 
[HAGL HAL] Initialising single buffered display.
[HAGL HAL] Initialising SPI.
[HAGL HAL] Baudrate is set to 62500000.
[HAGL HAL] clk_peri 125000000.
[HAGL HAL] clk_sys 125000000.
[HAGL HAL] Inverting display.
[main] 250840 free heap 
[main] 54296 VERTICAL LINES per second, 250528 free heap
[main] 67926 HORIZONTAL LINES per second, 250528 free heap

tuupola added 2 commits March 11, 2023 17:55
@tuupola
Remove buffers from hline and vline
705ae79 
For some reason this is around 50% slower atm:

50178 -> 24871 vertical lines per second
63583 -> 34266 horizontal lines per second
@tuupola
Inline the spi write
363c0a3 
Now it is fast again:

50178 -> 24871 -> 54296 vertical lines per second
63583 -> 34266 -> 67926 horizontal lines per second
@tuupola tuupola merged commit e8c82d7 into master Mar 11, 2023
@tuupola tuupola deleted the add-fill branch March 11, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tuupola