Use escape key to exit editing #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piturnah
force-pushed
the
feat/escape
branch
from
90d08b7 to
28e9f09
Compare
|
Marking as draft since I just noticed a critical bug, if you are renaming a todo and escape then it will delete it. Don't know how I didn't think of that. |
The escape key can now be used to exit edit mode. In writing a todo, this will also cancel the new todo.
Piturnah
force-pushed
the
feat/escape
branch
from
28e9f09 to
49d6628
Compare
Fixed! |
|
@Piturnah I like the enhancement. When I try editing and pressing |
|
Yeah, that is the functionality I intended - but I do agree that it may feel more intuitive to have it cancel the edit you made. If the maintainer agrees then I'd be happy to give a go implementing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The escape key can now be used to exit edit mode. In writing a todo, this will also cancel the new todo.