Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests #19

Closed
wants to merge 55 commits into from
Closed

Unit Tests #19

wants to merge 55 commits into from

Conversation

diegomarvid
Copy link
Collaborator

@diegomarvid diegomarvid commented May 18, 2024 •
edited
Loading

In this PR I will create unit tests for the repository. This is what has been done so far:

  • GenerateStep tests ✅
  • Added new unit testing GitHub action for pushing
  • EncodeStep tests ✅
  • TabularSplitStep tests. group_by_columns test is failing. We should fix this.
  • CalculateFeaturesStep tests ✅
  • CalculateMetricsStep tests ✅
  • CleanStep tests ✅
  • Add pipeline test for executing the pipeline without errors.
  • Fix important pipeline errors discovered in the tests.
  • ModelStep tests ✅
  • ModelRegistry tests ✅
  • StepRegistry tests ✅

Run tests

The tests can be run by the command:

pytest

You can run this command to see the test coverage in a HTML report

pytest --cov=pipeline_lib/core --cov-report=html tests/

Or by using the following VS Code extension Recommended

image

image

Current test coverage

image

@diegomarvid diegomarvid self-assigned this May 18, 2024
@diegomarvid diegomarvid force-pushed the unit-test branch 2 times, most recently from acaee31 to 51351c0 Compare May 19, 2024 02:05
ovejabu and others added 29 commits May 29, 2024 08:58
@ovejabu
Update readme
b5f13cd
@ovejabu
Update readme warning
e5b7ae8
@diegomarvid @froukje
create first unit test with pytest
1a6aa62
@diegomarvid @froukje
add unit testing gh workflow
5493994
@diegomarvid @froukje
add EncodeStep tests
b8578ea
@diegomarvid @froukje
minor refactor
3301385
@diegomarvid @froukje
add TabularSplit tests. group_by_columns test is FAILING
104ed26
@diegomarvid @froukje
add test for CalculateFeaturesStep
fee81a4
@diegomarvid @froukje
ensure pytest fixtures in first functions for encoding and tabular tests
474c60d
@diegomarvid @froukje
update encoding tests
6fc4c55
@diegomarvid @froukje
remove MAPE metric and add CalculateMetrics tests
643f511
@diegomarvid @froukje
add CleanStep tests
559cad7
@diegomarvid @froukje
fix unused import in calculate metrics test
7238a70
@diegomarvid @froukje
add pipeline test and fix important errors
3f48dc9
@diegomarvid @froukje
install poetry with extras in unit testing workflow
a72a32d
@diegomarvid @froukje
add test for ModelStep
2a9e414
@diegomarvid @froukje
add tests for ModelRegistry
b710e10
@diegomarvid @froukje
add tests for StepRegistry
4331029
@diegomarvid @froukje
delete unused files and functions
f40adc2
@diegomarvid @froukje
add log_experiment tests in pipeline tests
f0b7807
@diegomarvid @froukje
add ames housing testing performance to unit tests
9a751aa
@diegomarvid @froukje
fix style checks
75f7869
@froukje
style checks
fe3f73d
@froukje
adapt mlflow tests & log
c02cc74
@froukje
Update unit-testing.yaml
e8e6b6e
@froukje
test workflow
33eb9b9
@froukje
test workflow
7ba2558
@froukje
Merge branch 'unit-test' of github.com:tryolabs/pipeline-lib into uni…
6178249 
…t-test
@froukje
merge conflicts
53e1c02
@ovejabu ovejabu closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froukje froukje froukje approved these changes

@Ludecan Ludecan Awaiting requested review from Ludecan

@ovejabu ovejabu Awaiting requested review from ovejabu

Assignees

@diegomarvid diegomarvid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegomarvid @froukje @ovejabu