Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace cpu flag with fun clippy command #485

Closed
wants to merge 1 commit into from

Conversation

load1n9
Copy link
Member

@load1n9 load1n9 commented Dec 11, 2024

No description provided.

@eliassjogreen
Copy link
Member

Why??? 😭

@aapoalas
Copy link
Collaborator

Mm, I don't quite understand what this does. Can you explain a bit?

@load1n9
Copy link
Member Author

load1n9 commented Dec 11, 2024

@eliassjogreen have clippy while we figure out what flags we want

@eliassjogreen
Copy link
Member

Most likely we don't want any flags, and if we want any flags it's probably the one we have currently. So I say we keep it this way. Any possible build options we wan't to tweak we can do in the cargo profiles. E.g. opt-level, LTO, etc.

@MierenManz
Copy link
Collaborator

Do we currently provide builds? Or is everything build by the user?

Cuz we nee to remove the native cpu flag when providing builds because older systems may not support the features our build cpu does support

@eliassjogreen
Copy link
Member

No, we don't yet provide pre-built executables. Maybe if we should start distributing C-bindings and a pre-built dynamically linked libnova? But the nova cli is mainly for debugging purposes so I don't see any reason to distribute that.

@load1n9 load1n9 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants