feat(ecmascript): Infallible internal method variants #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
force-pushed
the
feat/ecmascript-try-internal-methods
branch
from
69b4ca2 to
83df218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added infallible internal method variants; these cannot call JS or throw errors. The latter restriction is perhaps a bit too harsh and might be removed later. Allowing eg. calling of some builtins would also be cool but will need further work. Allowing calling of some JS functions would also be freaking awesome, eg.
array.map(x => x.substring(5))orarray.filter(x => !x)or such would be great. The problem is of course that we'd need to know fairly deep things about the JS functions and the system in general.After I merge this, the next step will be using these try methods in various places to try and avoid GC as far as possible.