feat: bugfixes and massive simplification of DocumentQnA test (#51) #103
dotnet.yml
on: push
Build, test and publish
/
Build, test and publish
3m 18s
Annotations
10 warnings
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Base/TextSplitter.cs#L74
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L35
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L51
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L62
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L51
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L53
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L62
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Base/TextSplitter.cs#L75
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Base/TextSplitter.cs#L74
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Base/TextSplitter.cs#L75
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
nuget-packages
Expired
|
6.41 MB |
|