Skip to content

callbacks refactor

callbacks refactor #31

Triggered via pull request November 4, 2023 22:59
@khoroshevjkhoroshevj
synchronize #49
callbacks
Status Success
Total duration 2m 51s
Artifacts 1

pull-request.yml

on: pull_request
Build abd test  /  Build, test and publish
2m 42s
Build abd test / Build, test and publish
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L46
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L57
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L46
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L48
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L57
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L46
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L57
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L46
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)

Artifacts

Produced during runtime
Name Size
nuget-packages Expired
6.18 MB