Skip to content

callbacks refactor

callbacks refactor #30

Triggered via pull request November 4, 2023 22:53
Status Failure
Total duration 2m 43s
Artifacts

pull-request.yml

on: pull_request
Build abd test  /  Build, test and publish
2m 32s
Build abd test / Build, test and publish
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 10 warnings
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L31
The type or namespace name 'Callbacks' could not be found (are you missing a using directive or an assembly reference?)
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L31
Argument 3: cannot convert from 'Callbacks?' to 'LangChain.Callback.ICallbacks?'
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L55
The type or namespace name 'Callbacks' could not be found (are you missing a using directive or an assembly reference?)
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L59
The type or namespace name 'Callbacks' could not be found (are you missing a using directive or an assembly reference?)
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L31
The type or namespace name 'Callbacks' could not be found (are you missing a using directive or an assembly reference?)
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L31
Argument 3: cannot convert from 'Callbacks?' to 'LangChain.Callback.ICallbacks?'
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L55
The type or namespace name 'Callbacks' could not be found (are you missing a using directive or an assembly reference?)
Build abd test / Build, test and publish: src/tests/LangChain.Core.UnitTests/Chains/RetrievalQa/RetrievalQaChainTests.cs#L59
The type or namespace name 'Callbacks' could not be found (are you missing a using directive or an assembly reference?)
Build abd test / Build, test and publish
Process completed with exit code 1.
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L46
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L57
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L46
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L48
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L57
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Chains/CombineDocuments/StuffDocumentsChain.cs#L64
Nullability of reference types in value of type '(string?, Dictionary<string, object>)' doesn't match target type '(string Output, Dictionary<string, object> OtherKeys)'.
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L46
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
Build abd test / Build, test and publish: src/libs/LangChain.Core/Docstore/Document.cs#L57
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)