feat: LLamaSharp embeddings and test (#47) #100
dotnet.yml
on: push
Build, test and publish
/
Build, test and publish
2m 45s
Annotations
10 warnings
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/TextSplitters/RecursiveCharacterTextSplitter.cs#L60
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/TextSplitters/RecursiveCharacterTextSplitter.cs#L72
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L46
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L57
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L46
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L48
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L57
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/Chains/CombineDocuments/StuffDocumentsChain.cs#L64
Nullability of reference types in value of type '(string?, Dictionary<string, object>)' doesn't match target type '(string Output, Dictionary<string, object> OtherKeys)'.
|
Build, test and publish / Build, test and publish:
src/libs/LangChain.Core/TextSplitters/RecursiveCharacterTextSplitter.cs#L60
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
nuget-packages
Expired
|
6.15 MB |
|