TextLoader added #17
pull-request.yml
on: pull_request
Build abd test
/
Build, test and publish
3m 5s
Annotations
10 warnings
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L46
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L57
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L46
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L48
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L57
In method 'Lookup', replace the call to 'ToLower' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/TextSplitters/RecursiveCharacterTextSplitter.cs#L60
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/TextSplitters/RecursiveCharacterTextSplitter.cs#L72
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
|
Build abd test / Build, test and publish:
src/libs/LangChain.Core/Docstore/Document.cs#L46
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
nuget-packages
Expired
|
6 MB |
|