Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lmeval): Filter protected env vars set from CR directly #381

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

ruivieira
Copy link
Member

The LMEval Job CR allows to set env vars directly from the CR.
This PR disables setting protected vars (i.e. related to offline and code execution), thus overriding the offline/no execution CR settings.

Refer RHOAIENG-16885.

Copy link

github-actions bot commented Dec 11, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:3ed5f0ed4fb6decb92c54d3d8fef372b6783db92

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:3ed5f0ed4fb6decb92c54d3d8fef372b6783db92

📦 LMES job image: quay.io/trustyai/ta-lmes-job:3ed5f0ed4fb6decb92c54d3d8fef372b6783db92

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-3ed5f0ed4fb6decb92c54d3d8fef372b6783db92

Copy link

openshift-ci bot commented Dec 11, 2024

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e 31d279d link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobGeada

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# Conflicts:
#	controllers/lmes/lmevaljob_controller_test.go
@openshift-ci openshift-ci bot removed the lgtm label Dec 11, 2024
Copy link

openshift-ci bot commented Dec 11, 2024

New changes are detected. LGTM label has been removed.

@ruivieira ruivieira merged commit 8db3fab into trustyai-explainability:main Dec 11, 2024
5 of 6 checks passed
ruivieira added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants