-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lmeval): Filter protected env vars set from CR directly #381
feat(lmeval): Filter protected env vars set from CR directly #381
Conversation
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 🗂️ CI manifests
|
@ruivieira: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RobGeada The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# Conflicts: # controllers/lmes/lmevaljob_controller_test.go
New changes are detected. LGTM label has been removed. |
(cherry picked from commit 8db3fab)
The LMEval Job CR allows to set env vars directly from the CR.
This PR disables setting protected vars (i.e. related to offline and code execution), thus overriding the offline/no execution CR settings.
Refer RHOAIENG-16885.