Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Composer.json and namespaces to the classes #42

Closed
wants to merge 8 commits into from
Closed

Add Composer.json and namespaces to the classes #42

wants to merge 8 commits into from

Conversation

rvanlaak
Copy link

Please take a look at the attached code. I've added a composer file, which makes it possible to place the library on Packagist.

Aside of that, I also separated all classes and made one file per class. At top of the classes there now is a namespace.

Most of the code styling has been optimized for psr-0. None of the functions itself has been changed, this just makes it better maintainable.

@rvanlaak
Copy link
Author

The next thing in my opinion should be #40 , so that is what I'm going to think about next.

Before I start with the Symfony2 bundle, I would like to add an autoloader for the old users, so they can keep making use of the code identically as they did before. I've added TODO's to the original "tropo-rest.class.php" and "tropo.class.php" file.

@rvanlaak
Copy link
Author

In the latest commits I've fixed the use statements, so the last BC break should be an incorrect functioning autoloader.

@ghost ghost assigned kevinbond Jan 20, 2014
@rvanlaak rvanlaak closed this Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants