Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in README.md #70

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

JoanFM
Copy link
Contributor

@JoanFM JoanFM commented Nov 10, 2023

No description provided.

@oandreeva-nv
Copy link
Collaborator

Hi @JoanFM , thank you for fixing this! may I ask you to send us a CLA: https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla ?

Copy link
Collaborator

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was mentioned to me that this type of change may be merged without CLA, so leaving final decision to the contributor.

@tanmayv25 tanmayv25 merged commit ce3c9c0 into triton-inference-server:main Nov 22, 2023
3 checks passed
@amirhp110
Copy link

Hello,
My first time commenting on GitHub,
So excuse me on wrong people or place I am commenting on in advance.
In this README.md in the first step "Deploying a PyTorch Model" is mentioned to run "python export.py" but the docker does not have such file. Here is the command I used for the docker as suggested:
docker run -it --gpus all -v ${PWD}:/workspace nvcr.io/nvidia/pytorch:22.04-py3

Thanks in advance for your help,
Amir

@oandreeva-nv
Copy link
Collaborator

Hi @amirhp110 , make sure to run docker run -it --gpus all -v ${PWD}:/workspace nvcr.io/nvidia/pytorch:22.04-py3 from the downloaded folder PyTorch. This folder contains export.py: https://github.com/triton-inference-server/tutorials/blob/main/Quick_Deploy/PyTorch/export.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants