Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial to use tokenizer directory for consistency #110

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dyastremsky
Copy link
Contributor

Currently, the GenAI-Perf command in the Llama2 TRT-LLM guide uses the Hugging Face tokenizer name. However, the rest of the tutorial uses the tokenizer in the directory located at /Llama-2-7b-hf/. Based on user feedback, this PR updates the tutorial to use the filepath instead for consistency.

@dyastremsky dyastremsky self-assigned this Aug 28, 2024
@dyastremsky dyastremsky assigned rmccorm4 and unassigned rmccorm4 Aug 28, 2024
@dyastremsky dyastremsky requested a review from rmccorm4 August 28, 2024 16:09
Copy link
Collaborator

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

@dyastremsky dyastremsky merged commit 33b005f into main Aug 28, 2024
3 checks passed
@dyastremsky dyastremsky deleted the dyas-tokenizer-path branch August 28, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants