3 small improvements

[samejr]

1. Margin missing between the upgrade panel and the list of users. Now added:

2. I had to include an isSelected prop to the Table component to fix a style issue when a table row is selected.
3. Updated the login page logos
4. Updated the toast styles so they match the design. They are brighter and slightly more colorful.
   

Summary by CodeRabbit

• New Features

  • Introduced four new logo components: LyftLogo, MiddayLogo, TldrawLogo, and UnkeyLogo for enhanced branding.
  • Updated the LoginPageLayout to include the new logos, replacing three previous logos.
  • Enhanced the Table component to visually indicate selected rows and cells.
  • Improved Toast notifications with dynamic styling based on message type.
  • Added a panelClassName property to the InfoPanel for better layout in team management.
  • Updated messaging in the Story component with new success and error toast notifications.

• Bug Fixes

  • Refined error handling in the action function for clearer responses.

• Chores

  • Streamlined code structure for better readability and maintainability across various components.

[changeset-bot]

⚠️ No Changeset found

Latest commit: dad112c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/webapp/app/assets/logos/LyftLogo.tsx

Oops! Something went wrong! :(

ESLint: 8.45.0

ESLint couldn't find the config "custom" to extend from. Please check that the name of the config is correct.

The config "custom" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

This pull request introduces four new React functional components for logos: LyftLogo, MiddayLogo, TldrawLogo, and UnkeyLogo, each accepting an optional className prop for styling. These components render SVG representations of their respective logos. Additionally, the LoginPageLayout component is updated to replace three existing logos with the new ones. The Table, Toast, and various route components have been modified to enhance interactivity and styling, particularly through the introduction of an isSelected prop for visual feedback.

Changes

File Path	Change Summary
apps/webapp/app/assets/logos/LyftLogo.tsx	Added LyftLogo component, accepts className prop, renders Lyft logo SVG.
apps/webapp/app/assets/logos/MiddayLogo.tsx	Added MiddayLogo component, accepts className prop, renders Midday logo SVG.
apps/webapp/app/assets/logos/TldrawLogo.tsx	Added TldrawLogo component, accepts className prop, renders Tldraw logo SVG.
apps/webapp/app/assets/logos/UnkeyLogo.tsx	Added UnkeyLogo component, accepts className prop, renders Unkey logo SVG.
apps/webapp/app/components/LoginPageLayout.tsx	Updated to import and use new logo components; replaced VerizonLogo, ShopifyLogo, and ATAndTLogo.
apps/webapp/app/components/primitives/Table.tsx	Modified TableRow, TableCell, and TableCellMenu to include isSelected prop for conditional styling.
apps/webapp/app/components/primitives/Toast.tsx	Updated Toast and ToastUI components for conditional styling based on variant, modified icon classes, and button styles.
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.deployments/route.tsx	Updated DeploymentActionsCell to accept isSelected prop for styling; modified table rendering logic.
apps/webapp/app/routes/_app.orgs.$organizationSlug.team/route.tsx	Added panelClassName property to InfoPanel component, refined error handling in the action function.
apps/webapp/app/routes/storybook.toast/route.tsx	Modified Story component to adjust ToastUI instances and button styles.

Possibly related PRs

• New onboarding question #1404: The LyftLogo component introduced in the main PR is related to the MiddayLogo component, as both are new React functional components for logos that accept a className prop for styling.
• An improved 404 page design #1427: The LyftLogo is imported into the LoginPageLayout component, which is directly related to the changes made in the main PR where the LyftLogo component was added.
• Side help panel #1488: The new HelpAndFeedback component introduced in this PR may relate to the overall UI enhancements that include the LyftLogo as part of the branding in the application, although it does not directly modify the logo components.
• Deploy page table rows stay selected when the side menu is open #1492: The deployment page's visual feedback improvements could relate to the overall UI consistency that includes logo components like LyftLogo, enhancing user experience across the application.
• Adds a tooltip to the Status header showing deployment status descrip… #1554: The tooltip for deployment statuses may indirectly relate to the branding and visual consistency efforts that include the LyftLogo, as both aim to improve user interface clarity.

Suggested reviewers

• matt-aitken

Poem

🐰 In the meadow where logos play,
New friends join us, hip-hip-hooray!
Lyft and Midday hop in with cheer,
Tldraw and Unkey, all drawing near.
With colors bright and styles so fine,
Our branding shines, oh how divine! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b355ab and dad112c.

📒 Files selected for processing (10)

• apps/webapp/app/assets/logos/LyftLogo.tsx (1 hunks)
• apps/webapp/app/assets/logos/MiddayLogo.tsx (1 hunks)
• apps/webapp/app/assets/logos/TldrawLogo.tsx (1 hunks)
• apps/webapp/app/assets/logos/UnkeyLogo.tsx (1 hunks)
• apps/webapp/app/components/LoginPageLayout.tsx (2 hunks)
• apps/webapp/app/components/primitives/Table.tsx (7 hunks)
• apps/webapp/app/components/primitives/Toast.tsx (2 hunks)
• apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.deployments/route.tsx (4 hunks)
• apps/webapp/app/routes/_app.orgs.$organizationSlug.team/route.tsx (1 hunks)
• apps/webapp/app/routes/storybook.toast/route.tsx (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

@trigger.dev/build

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1560

@trigger.dev/react-hooks

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1560

@trigger.dev/rsc

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/rsc@1560

@trigger.dev/core

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1560

trigger.dev

npm i https://pkg.pr.new/triggerdotdev/trigger.dev@1560

@trigger.dev/sdk

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1560

commit: dad112c