Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lodash.omit import #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dariusk
Copy link

@dariusk dariusk commented Jul 31, 2024

It looks like via typo this module had accidentally been loading omit via lodash (the full lodash package itself, which is not included in package.json but is in the dependency tree elsewhere) and not via lodash.omit that is actually a dependency in package.json. This was causing some problems in downstream dependencies. Basically the full lodash package is available to this particular project via a string of devDependencies so the package builds just fine and even distributes fine, but if a downstream project does not have lodash anywhere in its dependencies it will break (since the devDependencies aren't distributed with the release).

This PR adds the @types needed for lodash.omit and changes the code to import lodash.omit itself.

dariusk added 2 commits July 31, 2024 08:34
This had been loading omit via `lodash` but not via `lodash.omit`, which was causing some problems in downstream dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant