Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like via typo this module had accidentally been loading omit via
lodash
(the full lodash package itself, which is not included inpackage.json
but is in the dependency tree elsewhere) and not vialodash.omit
that is actually a dependency inpackage.json
. This was causing some problems in downstream dependencies. Basically the fulllodash
package is available to this particular project via a string ofdevDependencies
so the package builds just fine and even distributes fine, but if a downstream project does not havelodash
anywhere in its dependencies it will break (since thedevDependencies
aren't distributed with the release).This PR adds the
@types
needed forlodash.omit
and changes the code to importlodash.omit
itself.