Standardize all output in JSON format #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissnell
force-pushed
the
origin
branch
3 times, most recently
from
f69b763 to
8bc49c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch formats the "Searching..." messages that appear before the ISS is synced as JSON. This makes it easier to parse the output of the device when it's first connected.
BTW, thanks so much for DavisSi1000. I stumbled upon this while investigating using a SDR to read the ISS broadcasts but struggled to understand GFSK demodulation. Bravo for finding the Si1000 and making this work. This is every bit as amazing as Samba was to me in 1993. :-)
For what it's worth, I'm using this successfully with a cheap (Chinese?) clone of the 3DR USB stick from eBay.