Optionally set mtime in linkPhysicalAddress (#8338)

* Add optional `mtime' to linkPhysicalAddress - Ignored by old servers - Tested: when a new client sends mtime to an old server, the old server ignores it. - Sets object mtime - This is like stageObject, so (almost) already available * Use optional `mtime' in linkPhysicalAddress
treeverse · Nov 5, 2024 · 5128ee9 · 5128ee9
1 parent bf98183
commit 5128ee9
Show file tree

Hide file tree

Showing 19 changed files with 114 additions and 3 deletions.
diff --git a/api/swagger.yml b/api/swagger.yml
@@ -1369,6 +1369,10 @@ components:
         content_type:
           type: string
           description: Object media type
+        mtime:
+          type: integer
+          format: int64
+          description: Unix Epoch in seconds.  May be ignored by server.
         force:
           type: boolean
           default: false

diff --git a/clients/java-legacy/api/openapi.yaml b/clients/java-legacy/api/openapi.yaml
diff --git a/clients/java-legacy/docs/StagingMetadata.md b/clients/java-legacy/docs/StagingMetadata.md
diff --git a/clients/java-legacy/src/main/java/io/lakefs/clients/api/model/StagingMetadata.java b/clients/java-legacy/src/main/java/io/lakefs/clients/api/model/StagingMetadata.java
diff --git a/clients/java-legacy/src/test/java/io/lakefs/clients/api/model/StagingMetadataTest.java b/clients/java-legacy/src/test/java/io/lakefs/clients/api/model/StagingMetadataTest.java
diff --git a/clients/java/api/openapi.yaml b/clients/java/api/openapi.yaml
diff --git a/clients/java/docs/StagingMetadata.md b/clients/java/docs/StagingMetadata.md
diff --git a/clients/java/src/main/java/io/lakefs/clients/sdk/model/StagingMetadata.java b/clients/java/src/main/java/io/lakefs/clients/sdk/model/StagingMetadata.java
diff --git a/clients/java/src/test/java/io/lakefs/clients/sdk/model/StagingMetadataTest.java b/clients/java/src/test/java/io/lakefs/clients/sdk/model/StagingMetadataTest.java
diff --git a/clients/python-legacy/docs/StagingApi.md b/clients/python-legacy/docs/StagingApi.md
diff --git a/clients/python-legacy/docs/StagingMetadata.md b/clients/python-legacy/docs/StagingMetadata.md
diff --git a/clients/python-legacy/lakefs_client/model/staging_metadata.py b/clients/python-legacy/lakefs_client/model/staging_metadata.py
diff --git a/clients/python/docs/StagingMetadata.md b/clients/python/docs/StagingMetadata.md
diff --git a/clients/python/lakefs_sdk/models/staging_metadata.py b/clients/python/lakefs_sdk/models/staging_metadata.py
diff --git a/clients/python/test/test_staging_metadata.py b/clients/python/test/test_staging_metadata.py
diff --git a/clients/rust/docs/StagingMetadata.md b/clients/rust/docs/StagingMetadata.md
diff --git a/clients/rust/src/models/staging_metadata.rs b/clients/rust/src/models/staging_metadata.rs
diff --git a/docs/assets/js/swagger.yml b/docs/assets/js/swagger.yml
@@ -1369,6 +1369,10 @@ components:
         content_type:
           type: string
           description: Object media type
+        mtime:
+          type: integer
+          format: int64
+          description: Unix Epoch in seconds.  May be ignored by server.
         force:
           type: boolean
           default: false

diff --git a/pkg/api/controller.go b/pkg/api/controller.go
@@ -769,6 +769,9 @@ func (c *Controller) LinkPhysicalAddress(w http.ResponseWriter, r *http.Request,
 	}
 
 	writeTime := time.Now()
+	if mtime := body.Mtime; mtime != nil {
+		writeTime = time.Unix(*mtime, 0)
+	}
 	fullPhysicalAddress := swag.StringValue(body.Staging.PhysicalAddress)
 	physicalAddress, addressType := normalizePhysicalAddress(repo.StorageNamespace, fullPhysicalAddress)