Skip to content

Commit

Permalink
e2e: fix monitoring time test instability
Browse files Browse the repository at this point in the history
In order for all of the reports to have non-zero volume, more precise
timing is needed, which is hard to achieve in the current CI
environment.
  • Loading branch information
ivan4th authored and sergeymatov committed Oct 18, 2021
1 parent 006fd23 commit 4146283
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/e2e/upg_e2e.go
Original file line number Diff line number Diff line change
Expand Up @@ -638,9 +638,7 @@ var _ = ginkgo.Describe("[Reporting]", func() {
gomega.Expect(beforeSplit.EndTime).To(gomega.Equal(monitoringTime))
gomega.Expect(afterSplit.StartTime).To(gomega.Equal(monitoringTime))
gomega.Expect(beforeSplit.TotalVolume).NotTo(gomega.BeNil())
gomega.Expect(*beforeSplit.TotalVolume).NotTo(gomega.BeZero())
gomega.Expect(afterSplit.TotalVolume).NotTo(gomega.BeNil())
gomega.Expect(*afterSplit.TotalVolume).NotTo(gomega.BeZero())

ul, dl := getTrafficCountsFromCapture(f, layers.IPProtocolUDP, nil)
framework.ExpectEqual(firstUL+*beforeSplit.UplinkVolume+*afterSplit.UplinkVolume, ul,
Expand Down Expand Up @@ -742,11 +740,9 @@ var _ = ginkgo.Describe("[Reporting]", func() {
gomega.Expect(before.EndTime).To(gomega.Equal(monitoringTimes[n]))
gomega.Expect(after.StartTime).To(gomega.Equal(monitoringTimes[n]))
gomega.Expect(before.TotalVolume).NotTo(gomega.BeNil(), "total volume before (report %d)", n)
gomega.Expect(*before.TotalVolume).NotTo(gomega.BeZero(), "total volume before (report %d)", n)
framework.ExpectEqual(*before.UplinkVolume+*before.DownlinkVolume,
*before.TotalVolume, "bad total volume (split %d)", n)
gomega.Expect(after.TotalVolume).NotTo(gomega.BeNil(), "total volume after (report %d)", n)
gomega.Expect(*after.TotalVolume).NotTo(gomega.BeZero(), "total volume after (report %d)", n)
framework.ExpectEqual(*after.UplinkVolume+*after.DownlinkVolume,
*after.TotalVolume, "bad total volume (split %d)", n)

Expand Down

0 comments on commit 4146283

Please sign in to comment.