Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ make proxy wait for plugin registry #169

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

NEwa-05
Copy link
Collaborator

@NEwa-05 NEwa-05 commented Dec 11, 2024

What does this PR do?

This feature lets you enable an initContainer when the proxy starts to validate that the plugin registry is accessible.

Motivation

A customer reports an issue with its proxy failing to start if the plugin registry is not available.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@NEwa-05 NEwa-05 added kind/enhancement a new or improved feature. status/2-needs-review labels Dec 11, 2024
@darkweaver87 darkweaver87 changed the title Feat - Make proxy wait for plugin registry feat: ✨ make proxy wait for plugin registry Dec 11, 2024
@NEwa-05 NEwa-05 requested a review from nmengin December 11, 2024 12:40
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested, it works fine ;-)

traefikee/values.yaml Outdated Show resolved Hide resolved
@traefiker traefiker merged commit 8071c77 into traefik:master Dec 12, 2024
1 check passed
@NEwa-05 NEwa-05 removed the request for review from nmengin December 12, 2024 09:46
@NEwa-05 NEwa-05 deleted the proxy_wait branch December 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants