Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: custom date picker #456

Merged
merged 18 commits into from
Nov 6, 2024

Conversation

mdeliatf
Copy link
Contributor

@mdeliatf mdeliatf commented Nov 4, 2024

Description

This PR replaces react-datepicker with a custom component built on top of @rehookify/datepicker.

This modification will enable full customization of the date-time picker and resolve an issue that Vite encounters with .css files in the node_modules folder.

Preview

Screenshot 2024-11-04 alle 09 48 45
Screenshot 2024-11-04 alle 09 48 19

Dependency changes

Dependency Version State
@floating-ui/react ^0.26.25 Added
@rehookify/datepicker ^6.6.7 Added
@radix-ui/react-popover ^1.0.2 -> ^1.1.2 Updated
eslint-plugin-jsx-a11y ^6.9.0 -> ^6.10.1 Updated
eslint-plugin-react ^7.34.4 -> ^7.37.1 Updated
eslint-plugin-react-hooks ^4.6.2 -> ^5.0.0 Updated
typescript-eslint ^7.16.0 -> ^8.11.0 Updated
react-datepicker ^7.3.0 Removed

Breaking changes

Different date-time picker component.

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@mdeliatf mdeliatf requested a review from gndz07 November 4, 2024 08:47
@mdeliatf mdeliatf self-assigned this Nov 4, 2024
@mdeliatf mdeliatf force-pushed the feat/remove-react-datepicker branch from 3b3080e to 233d1bf Compare November 4, 2024 08:55
Copy link
Member

@gndz07 gndz07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3a475d4 into traefik:master Nov 6, 2024
2 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants