Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table nested in collapsible row separator #454

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

gndz07
Copy link
Member

@gndz07 gndz07 commented Oct 17, 2024

Description

We avoid the last element in every table to have a bottom border by styling its children <td />. However, the CSS selector is selecting all descendants, and not only direct children, which caused nested table to have no border at all for every last element.

Preview

Before:
image

After:
image

Copy link
Contributor

@mdeliatf mdeliatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@traefiker traefiker merged commit 3b26448 into traefik:master Oct 17, 2024
2 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 10.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing border on collapsible row
3 participants