Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add navigation menu #441

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

mdeliatf
Copy link
Contributor

@mdeliatf mdeliatf commented Jul 22, 2024

Description

  • Add navigation menu from Radix Primitives
  • Add width: 100% to NavigationItem to allow it to grow even when it's not contained inside a flexbox
  • Update Storybook and related plugins
  • Upgrade Prettier

Preview

Screenshot 2024-07-22 alle 17 55 51
Screenshot 2024-07-22 alle 17 56 16

Dependency changes

Dependency Version State
@radix-ui/react-navigation-menu ^1.2.0 Added
@storybook/addon-docs ^8.2.2 -> ^8.2.5 Updated
@storybook/addon-essentials ^8.2.2 -> ^8.2.5 Updated
@storybook/builder-vite ^8.2.2 -> ^8.2.5 Updated
@storybook/react ^8.2.2 -> ^8.2.5 Updated
@storybook/react-vite ^8.2.2 -> ^8.2.5 Updated
prettier ^2.1.2 -> ^3.3.3 Updated
storybook ^8.2.2 -> ^8.2.5 Updated

Breaking changes

None.

How to test?

nvm use
yarn
yarn storybook

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@mdeliatf mdeliatf force-pushed the feat/add-navigation-menu branch from 7fb96e7 to 4932e40 Compare July 22, 2024 08:55
@mdeliatf mdeliatf marked this pull request as ready for review July 23, 2024 07:40
Copy link

@jspdown jspdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 236407b into traefik:master Jul 23, 2024
2 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants