fix: use TypeScript v5 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeliatf
approved these changes
May 27, 2024
There was a problem hiding this comment.
yarn build does not work in my environment, but it's a CI script and I can see that it works there without any problems, so
EDIT: After removing manually the dist folder, yarn build started to work! Thanks @gndz07 🙏
|
🎉 This PR is included in version 10.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The use of outdated TS version raises several problems, for example this issue on Hub UI. We have tried to upgrade TS before, but we were blocked by stitches that is not fully supporting TS after v4.5.5 (example of known issue with stitches). There are some workarounds to suppress these errors raised by stitches, so please do not get alarmed by these.
Fixes https://github.com/traefik/hub-ui/issues/1146.