Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install dev deps on gh actions (part 2) #427

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: install dev deps on gh actions (part 2) #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d458abb
fix: replace some npm commands with yarn
mdeliatf Apr 16, 2024
c82dd7e
fix: install some more dev dependencies on GitHub actions
mdeliatf Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run pre-commit
yarn pre-commit
8 changes: 6 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ You can find the Storybook with an example for every component in this library [

```sh
npm install @traefiklabs/faency@next

# or

yarn add @traefiklabs/faency@next
```

Then you need to wire up the FaencyProvider which will hold the context with the Theme configuration and everything global that the components will need to work well.
Expand Down Expand Up @@ -51,13 +55,13 @@ docker run -it -v $(pwd):/usr/local/src/ -w /usr/local/src/ -p 3000:3000 node:la
- Install the project dependencies

```sh
npm install
yarn install
```

- Run the Storybook

```sh
npm run storybook
yarn storybook
```

At this point, Storybook should automatically open up in your browser and you can start coding, it has hot reload so it will automatically re-render whenever a change is detected on the code.
Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"scripts": {
"prettier": "prettier --write .",
"build": "rollup -c",
"release": "npm run build && np",
"release": "yarn build && np",
"storybook": "cross-env NODE_OPTIONS=--openssl-legacy-provider storybook dev -p 6006 -h localhost",
"storybook-docs": "storybook dev --docs",
"build-storybook": "cross-env NODE_OPTIONS=--openssl-legacy-provider storybook build",
Expand Down Expand Up @@ -107,8 +107,12 @@
"@types/tinycolor2": "^1.4.3",
"babel-loader": "^8.2.2",
"conventional-changelog-conventionalcommits": "^4.6.3",
"cross-env": "^7.0.3",
"husky": "^8.0.0",
"lint-staged": "13.1.0",
"lodash.merge": "^4.6.2",
"np": "^8.0.4",
"prettier": "^2.1.2",
"react": "18.2.0",
"react-dom": "18.2.0",
"rollup": "^2.70.1",
Expand All @@ -125,12 +129,8 @@
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"babel-jest": "^27.5.1",
"cross-env": "^7.0.3",
"husky": "^8.0.0",
"jest": "^27.5.1",
"jest-axe": "^6.0.0",
"lint-staged": "13.1.0",
"prettier": "^2.1.2"
"jest-axe": "^6.0.0"
},
"publishConfig": {
"access": "public",
Expand Down