Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/conv transpose2d #574

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Feat/conv transpose2d #574

merged 4 commits into from
Aug 3, 2023

Conversation

nathanielsimard
Copy link
Member

Related Issues/PRs

Partial Fix #540 (ConvTranspose1D to be done in a following PR)

Changes

Change the init method for all convolution modules to be similar to PyTorch.

Conv1D: https://pytorch.org/docs/stable/generated/torch.nn.Conv1d.html
Conv2D: https://pytorch.org/docs/stable/generated/torch.nn.Conv2d.html
ConvTranspose2D: https://pytorch.org/docs/stable/generated/torch.nn.ConvTranspose2d.html

Fix init methods, shapes and documentation when using groups > 1

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

burn-core/src/nn/conv/conv1d.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @louisfd if we can use the existing initializer then we should it it.

I also had a comment about group divisibility.

burn-core/src/nn/conv/conv2d.rs Show resolved Hide resolved
burn-core/src/nn/conv/conv_transpose2d.rs Show resolved Hide resolved
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing the issues.

@nathanielsimard nathanielsimard merged commit 597eab5 into main Aug 3, 2023
@nathanielsimard nathanielsimard deleted the feat/conv_transpose2d branch August 3, 2023 19:42
@ZhenArch
Copy link

ZhenArch commented Aug 4, 2023

你好,我有一个请求,就是能够实现一下上采样吗?(Upsample),类似https://pytorch.org/docs/stable/generated/torch.nn.Upsample.html

@antimora
Copy link
Collaborator

antimora commented Aug 4, 2023

@Zheby

你好,我有一个请求,就是能够实现一下上采样吗?(Upsample),类似https://pytorch.org/docs/stable/generated/torch.nn.Upsample.html

Please file a separate ticket. There is a related ticket: #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support Convolution transposed backward
4 participants