-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConvTranspose1d ONNX op #2349
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
- Coverage 85.38% 85.22% -0.16%
==========================================
Files 770 786 +16
Lines 98899 104088 +5189
==========================================
+ Hits 84441 88706 +4265
- Misses 14458 15382 +924 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the op!
Implementation looks good, just a minor comment regarding padding.
Thanks to your comment it actually made me realize that the other conv transpose ops don't check the padding correctly 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for fixing the other conv transpose padding discrepancies 🎉
@laggui
Involved functions will be padding_config_1d, padding_config_2d, padding_config_3d, and conv_transpose1d_config, conv_transpose2d_config, conv_transpose3d_config. Thank you in advance. |
I actually was thinking about that while reading your changes, but I don't think it is worth it right now. The number of lines reduced just to have one function do the check isn't much, and the current checks make it more explicit for each op. |
Ok, fine. |
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1714
Changes
Add ConvTranspose1d ONNX op in accordance with other conv transposed d onnx.
Testing
run-checks all
has passed.