feat: added reduce min onnx import #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
+ Coverage 86.07% 86.09% +0.02%
==========================================
Files 781 781
Lines 91616 91822 +206
==========================================
+ Hits 78861 79058 +197
- Misses 12755 12764 +9 ☔ View full report in Codecov by Sentry. |
laggui
reviewed
Jun 17, 2024
Comment on lines
16
to
21
| # ReduceMax, keepdims=0, axes=None | ||
| torch.min(x), | ||
| # ReduceMax, keepdims=1, axes=[1] | ||
| torch.min(x, dim=1, keepdim=True).values, | ||
| # ReduceMax, keepdims=1, axes=[-1] | ||
| torch.min(x, dim=-1, keepdim=True).values, |
There was a problem hiding this comment.
I'm assuming the comments are supposed to refer to ReduceMin?
We can change the comments to reflect the actual op.
JachymPutta
force-pushed
the
jp/reduce_min_onnx
branch
from
511d9e8 to
283e0d8
Compare
It was a great source of inspiration 😄 |
laggui
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks allscript has been executed.Related Issues/PRs
Helps with #1714
Changes
Reduce min import based on the reduce max
Testing
Manual
cargo test -p burn-import --color=always -- --color=alwayscargo test -p onnx-tests --color=always