Use core::error::Error for no-std (#2346)

tracel-ai · Oct 30, 2024 · 5989cf3 · 5989cf3
1 parent ff371de
commit 5989cf3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/crates/burn-core/src/config.rs b/crates/burn-core/src/config.rs
@@ -28,9 +28,7 @@ impl core::fmt::Display for ConfigError {
     }
 }
 
-// TODO: Move from std to core after Error is core (see https://github.com/rust-lang/rust/issues/103765)
-#[cfg(feature = "std")]
-impl std::error::Error for ConfigError {}
+impl core::error::Error for ConfigError {}
 
 /// Configuration trait.
 pub trait Config: serde::Serialize + serde::de::DeserializeOwned {

diff --git a/crates/burn-core/src/record/recorder.rs b/crates/burn-core/src/record/recorder.rs
@@ -171,9 +171,7 @@ impl core::fmt::Display for RecorderError {
     }
 }
 
-// TODO: Move from std to core after Error is core (see https://github.com/rust-lang/rust/issues/103765)
-#[cfg(feature = "std")]
-impl std::error::Error for RecorderError {}
+impl core::error::Error for RecorderError {}
 
 pub(crate) fn bin_config() -> bincode::config::Configuration {
     bincode::config::standard()