Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure that re-exported symbols show feature label in root #754

Merged
merged 5 commits into from
Jul 20, 2024
Merged

ensure that re-exported symbols show feature label in root #754

merged 5 commits into from
Jul 20, 2024

Conversation

GlenDC
Copy link
Contributor

@GlenDC GlenDC commented Dec 4, 2023

closes #743

@GlenDC GlenDC mentioned this pull request Dec 4, 2023
Closed
jplatte
jplatte reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this? We are already using doc_auto_cfg so I don't think these doc(cfg) attributes should make a difference. If my memory serves me right, it might instead help to put the doc(cfg) on the definition of those items, rather than the re-exports.

@GlenDC
Copy link
Contributor Author

GlenDC commented Dec 5, 2023

@jplatte in my test it didn't show up before and it did show after (locally using the right --cfg flags etc).

Whether it's the right solution I do not know. Feel free to propose or guide me into doing something different if you think I approached it wrong.

@jplatte
Copy link
Contributor

jplatte commented Dec 5, 2023

Okay, if you did test it then I have no concerns.

@tobz tobz added C-enhancement Category: A PR with an enhancement or a proposed on in an issue. T-docs Topic: documentation A-make Area: The tower "make" module A-util Area: The tower "util" module labels Jul 20, 2024
@tobz tobz merged commit 032d17f into tower-rs:master Jul 20, 2024
14 checks passed
@tobz tobz added the S-awaiting-release Status: approved/merged but awaiting a release. label Jul 20, 2024
@tobz
Copy link
Member

tobz commented Aug 13, 2024

This has been released as part of [email protected].

Thanks again for your contribution!

@tobz tobz removed the S-awaiting-release Status: approved/merged but awaiting a release. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte left review comments

@tobz tobz tobz approved these changes

Assignees
No one assigned
Labels
A-make Area: The tower "make" module A-util Area: The tower "util" module C-enhancement Category: A PR with an enhancement or a proposed on in an issue. T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tower::service_fn docs don't say that you need the util flag
3 participants
@GlenDC @jplatte @tobz