This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
Introduce client::Background #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A public named type for the background task future, needed to make the signature of the Service trait implementation of Connect usable with generic executor types. Replaces ConnectExecutor.
LucioFranco
suggested changes
Jun 3, 2019
mzabaluev
force-pushed
the
client-background
branch
from
d0ad5ff to
492940f
Compare
mzabaluev
added a commit
to mzabaluev/tower-hyper
that referenced
this pull request
Jun 4, 2019
As per discussion in tower-rs#46
Respecified and blanket implemented in terms of client::Background. Make it a public type as well.
As per discussion in tower-rs#46
mzabaluev
force-pushed
the
client-background
branch
from
492940f to
bea987b
Compare
ConnectExecutor is a utility trait to bind generic type parameters as supplied by the API user and expose their bounds required for an executor. Relegating part of it to LiftBody does not make sense.
LucioFranco
approved these changes
Jun 4, 2019
carllerche
reviewed
Jun 4, 2019
| mod connect; | ||
| mod connection; | ||
| mod future; | ||
|
|
||
| pub use self::connect::{Connect, ConnectError}; | ||
| pub use self::background::Background; |
There was a problem hiding this comment.
I don't believe the type needs to be re-exported. It can be "sealed".
There was a problem hiding this comment.
With the public ConnectExecutor, the only reason to have Background public is for completeness of documentation.
There was a problem hiding this comment.
The downside is it is now part of the public API, meaning changes to the type == breaking change.
There was a problem hiding this comment.
It was not published in a crates.io release, so it's not too late for #49 to fix this 😄
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A public named type for the background task future, needed to make the signature of the
Servicetrait implementation ofConnectusable with generic executor types.ReplacesTheConnectExecutorConnectExecutoralias trait uses this type as the parameter for itsTypedExecutorprerequisite and is made public.Fixes #44