Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support SKIP_INSTALL_SIMPLE_GIT_HOOKS env #107

Merged
merged 3 commits into from
Mar 13, 2024
Merged

feat: support SKIP_INSTALL_SIMPLE_GIT_HOOKS env #107

merged 3 commits into from
Mar 13, 2024

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 11, 2024

close #99

@toplenboren
Copy link
Owner

Hey! Thanks for the PR

Can you please double check yarn.lock? Its strange that the list of dependencies is not changed, but yarn.lock is changed

@JounQin
Copy link
Contributor Author

JounQin commented Mar 11, 2024 •
edited
Loading

@toplenboren It seems yarn.lock not been updated for quite a long time.

See https://github.com/toplenboren/simple-git-hooks/pull/107/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR1053

simple-git-hooks/package.json

Line 44 in 1bb083d

"clean-publish": "^4.2.0",

toplenboren
toplenboren reviewed Mar 11, 2024
View reviewed changes
simple-git-hooks.test.js Show resolved Hide resolved
README.md Show resolved Hide resolved
toplenboren
toplenboren approved these changes Mar 11, 2024
View reviewed changes
Copy link
Owner

@toplenboren toplenboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

JounQin
JounQin commented Mar 11, 2024
View reviewed changes
cli.js Show resolved Hide resolved
@toplenboren
Copy link
Owner

Anyway.. I think we are good to go :) please merge when you are ready

@JounQin
Copy link
Contributor Author

JounQin commented Mar 13, 2024

So, it's ready to merge.

@toplenboren toplenboren merged commit f8b9b94 into toplenboren:master Mar 13, 2024
4 checks passed
@JounQin JounQin deleted the feat/skip branch March 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toplenboren toplenboren toplenboren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Add a new option to skip enabling on CI
2 participants
@JounQin @toplenboren