-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 support #174
Python 3.13 support #174
Conversation
closes #173 |
It looks for me like you are building everything but the 3.13. since this isn't configured on main / master. |
Yep, might be best to create the PR from the develop branch, but it looks like CI also needs to be updated to include 3.13 there too. |
I would recommend adding a Bild on push vor all branches for a while and revert that after merging if necessary.
Am 29. Oktober 2024 02:15:20 MEZ schrieb Scott White ***@***.***>:
…Yep, might be best to create the PR from the develop branch, but it looks like CI also needs to be updated to include 3.13 there too.
--
Reply to this email directly or view it on GitHub:
#174 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Agreed, at least for the dev branch. Will wait for Tommy to weigh in, just wanted to move things along. The PR looks good to me. Thanks Philipp! |
It was nice to see how other people build c extensions. |
Please tag soon. |
Yes. I think perhaps the CI/CD should build on all PRs. Just to "test" that everything runs. I will merge this now and change a few things. |
Hi again. Merged and ran the deployment action now. Files are up on pypi: https://pypi.org/project/KDEpy/1.1.10/#files If anyone wants to think about ways to simplify the GH actions pipeline with me, that would be appreciated. I see that I started on a PR on this a while ago, but never merged it. |
Please tag a new version. All user/build caches need to be invalidated otherwise. |
New version added :) |
Python 3.13 need cython 3.
Increased cibuildwheel to its current version.
Some type conversions needed to be cast manually.