Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 support #174

Merged
merged 16 commits into from
Oct 29, 2024
Merged

Python 3.13 support #174

merged 16 commits into from
Oct 29, 2024

Conversation

philipp-horstenkamp
Copy link
Contributor

@philipp-horstenkamp philipp-horstenkamp commented Oct 29, 2024

Python 3.13 need cython 3.
Increased cibuildwheel to its current version.
Some type conversions needed to be cast manually.

@philipp-horstenkamp philipp-horstenkamp changed the title Draft: Python 3.13 support Python 3.13 support Oct 29, 2024
@philipp-horstenkamp
Copy link
Contributor Author

closes #173

@philipp-horstenkamp
Copy link
Contributor Author

It looks for me like you are building everything but the 3.13. since this isn't configured on main / master.

@whitews
Copy link
Collaborator

whitews commented Oct 29, 2024

Yep, might be best to create the PR from the develop branch, but it looks like CI also needs to be updated to include 3.13 there too.

@philipp-horstenkamp
Copy link
Contributor Author

philipp-horstenkamp commented Oct 29, 2024 via email

@whitews
Copy link
Collaborator

whitews commented Oct 29, 2024

Agreed, at least for the dev branch. Will wait for Tommy to weigh in, just wanted to move things along. The PR looks good to me. Thanks Philipp!

@philipp-horstenkamp
Copy link
Contributor Author

It was nice to see how other people build c extensions.

@philipp-horstenkamp
Copy link
Contributor Author

Please tag soon.
I need this for a project of mine.

@tommyod
Copy link
Owner

tommyod commented Oct 29, 2024

Yes. I think perhaps the CI/CD should build on all PRs. Just to "test" that everything runs.

I will merge this now and change a few things.

@tommyod tommyod merged commit 2a56505 into tommyod:master Oct 29, 2024
15 checks passed
@tommyod
Copy link
Owner

tommyod commented Oct 29, 2024

Hi again. Merged and ran the deployment action now. Files are up on pypi: https://pypi.org/project/KDEpy/1.1.10/#files

If anyone wants to think about ways to simplify the GH actions pipeline with me, that would be appreciated. I see that I started on a PR on this a while ago, but never merged it.

@philipp-horstenkamp
Copy link
Contributor Author

Please tag a new version. All user/build caches need to be invalidated otherwise.

@tommyod
Copy link
Owner

tommyod commented Oct 29, 2024

New version added :)

@philipp-horstenkamp philipp-horstenkamp deleted the python-313 branch October 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants