Replaced numpy.asfarray with numpy.asarray using the proper dtype. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain why this is needed? Some tests are failing. Please take a look |
|
Hi. The asfarray is deprecated in numpy >= 2. To use KDEpy with numpy >= 2 it must be replaced with asarray. It corresponds to the issue #168. Why the test fail, I dont know though. I will have a look. |
|
Great, thanks! |
|
I Solved the issues for the windows builds. I dont know why it is not running for ubuntu and macOS. |
Changed doctest to use assert
|
Changed dtype from int32 to long. Hope it solves also the issues on macOS and Ubuntu |
|
@tommyod all checks have passed. Do you need anything else from me? Can you please merge in the near future. |
|
Merged! Thanks for the contribution @SergejKr ! |
tommyod
added a commit
that referenced
this pull request
Sep 6, 2024
* Fix Numpy and Scipy deprecation warnings (#163) * fix numpy deprecation (product to prod) * fix numpy deprecation (brentq) * fix numpy deprecation (quad/nquad) * changes to meet PEP-8 * Fix flake8 and black formatting errors * Bump version to 1.1.9 (#164) Co-authored-by: tommyod <tommy.odland> * Update build.yml with pypi API token (#165) * Update build.yml with pypi API token * Remove push condition * Replaced numpy.asfarray with numpy.asarray using the proper dtype. (#169) * Replaced numpy.asfarray with numpy.asarray using the proper dtype. * Newer version of numpy return np.True_ instead of True. Changed this in two doctests. * Changed to correct dtype from int32 to long. Changed doctest to use assert --------- Co-authored-by: skrylow <[email protected]> * Version 1.1.10 with numpy 2.0 support (#171) --------- Co-authored-by: yanbomb <[email protected]> Co-authored-by: SergejKr <[email protected]> Co-authored-by: skrylow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I executed the unit tests with python 3.9 and 3.12. Everything was okay.