Remove unnecessary instructions for Mac OS X #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing or scoring, Window.Location.getHref() is mocked by an argument original_url. Instead of just replacing the domain by the original_domain parameter, the path and scheme can also be replaced now. This removes the sensitivity to the path where the dom distiller repo is checked out, and this could make scoring more real after the scoring server also adds support. After this change, "Disable some tests in PagingLinksFinderTest" can be reverted. This change is related to https://codereview.chromium.org/887803002/. BUG=425952 [email protected] Review URL: https://codereview.chromium.org/867833002
In revision "Tune the next-page algorithm to reduce false positives", there are some tests added, but they need to follow the convention in revision "Mock Window.Location.getHref() in PagingLinksFinderTest". [email protected] Review URL: https://codereview.chromium.org/886213002
The word "article" was added to extraneous list in revision "Tune the next-page algorithm to reduce false positives", but revision "Mock Window.Location.getHref() in PagingLinksFinderTest" used it in the page URL, and caused regressions for some of the disabled tests in PagingLinksFinderTest. [email protected] Review URL: https://codereview.chromium.org/893733002
This reverts commit ddb81f8. After revision "Mock Window.Location.getHref() in PagingLinksFinderTest", the sensitivity to the path where the dom distiller repo is checked out is gone. After revision "Fix the page URL in PagingLinksFinderTest", the regression caused by "extraneous words" in the URL is gone. [email protected] Review URL: https://codereview.chromium.org/891103002
[email protected] Committed: 0efb1b473ee0c3c6ad2f9e951064f245e9c5fafe Review URL: https://codereview.chromium.org/860913002
Depending on package requires that we do the normal optimized gwt compilation. This basically doubles the time it takes to run tests and doesn't really gain us anything. [email protected] Committed: d35445ec6897bb90882bee1899e30c67213a0063 Review URL: https://codereview.chromium.org/884043005
- Adds the JS tests to the package so the JS tests can be run in chromium. - Adds support for suppressing all log output (except the log builder), so the log can be fetched directly from the log builder when running the tests in Chromium. This is set by setting console_log=0 in the URL for the test page, or when running run_jstests.py just add --console_log=0 as a parameter. - Moves the parsing of the debug_level when running tests to run() from runWithFilter() in JsTestEntry. [email protected] Review URL: https://codereview.chromium.org/879893003
- Adds documentation for development environment setup on Mac OS X. - Adds two conditions to the build.xml file to separate 'linux' and 'mac' OS versions. This is used to ensure that xvfb-run is not used on Mac OS X. [email protected] Review URL: https://codereview.chromium.org/887983002
This CL adds instructions for how to setup the buildtools folder for getting `git cl format` to work. [email protected] Review URL: https://codereview.chromium.org/896323002
This change adds extraction of popular embedded elements common in web pages. Each type of embed has its own extractor that attempts to pull out specific information including associated IDs, width, height, and original URL. Though many embeds normally end up in some form of iframe, their original state is not necessarily that. Embeds that start out as a div or blockquote have their respective extractors account for both. BUG= [email protected], [email protected] Review URL: https://codereview.chromium.org/804023006
The standalone JavaScript file needs to be wrapped when injected into real pages in Chrome, to ensure that it does not change the real window object. This CL adds such a wrapper JavaScript and functionality to automatically build it when packaging the output. BUG=455503 [email protected] Review URL: https://codereview.chromium.org/863863007
BUG=431067 [email protected] Review URL: https://codereview.chromium.org/864343007
This simplifies link resolution, but the speed is still roughly the same as manual resolution. Perf scoring goes through the same code path as the real case, so it's more realistic now. [email protected] Review URL: https://codereview.chromium.org/901843002
The behavior is almost exactly the same, except for links with the same hostname but different schemes (from http://example.com/page.html to https://example.com/next.html), which are usually not what we want. After this optimization, pagination time is reduced to 60%. BUG=431067 [email protected] Review URL: https://codereview.chromium.org/902813002
If base tag exists, original_url would be updated accordingly. [email protected] Review URL: https://codereview.chromium.org/904473006
Existence of numbers is done after matching baseUrl against the link URL, which is accurate but slower. If a link has no number at all in its path part, it won't match for next page, and is fast to filter out. After this optimization, pagination time is reduced to 75%. Combined with the URL prefix filter, the pagination time is reduced to around 60% * 75% = 45%. BUG=431067 [email protected] Review URL: https://codereview.chromium.org/899093004
A bad URL could gain high score simply by appearing for numerous
times, or alternatively, a correct URL can look bad due to negative
scores from other links with the same URL. So we just went ahead
and fixed the glitch.
Changes in next page dataset:
1 Has/Not -> Has/Rt
1 Has/Wr -> Has/Rt
1 Has/Rt -> Has/Not
Overall:
Next Has/Rt Next Not/Not
COUNTS 28/33 => 29/33 71/72
BUG=450813
[email protected]
Review URL: https://codereview.chromium.org/893343004
Try to extract the page number from current URL and the link. If the
difference of page number is 1 or -1 in next/prev page detection,
add score to that link.
Next Has/Rt Next Not/Not
COUNTS 29/33 => 32/33 71/72
[email protected]
Review URL: https://codereview.chromium.org/905393003
Merge pull request #1 from chromium/master
pull changes from upstream
There is no point in specifying incorrect instructions for Mac OS X.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in specifying incorrect instructions for Mac OS X.