Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wifi support for ROS 7.13+ devices without a physical wifi radio #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvn23
Copy link

@mvn23 mvn23 commented Oct 9, 2024

Proposed change

My CCR2004 has no physical wifi radio, but can manage CAPs through the wifi menu.
Since ROS 7.13, this is no longer a separate package (only routeros is listed under packages).
With this PR, we add support for this scenario by disabling capsman and setting the _wifimodule to wifi if we're running on ROS 7.13 or later.

Type of change

  • Bugfix
  • New feature
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Note: The code was not formatted with black as that would have resulted in a lot of unrelated changes.

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • Tests have been added to verify that the new code works.
  • Documentation added/updated if required.

@brezuicabogdan
Copy link

I have been testing this branch for the last 24 hours on ROS 7.16and wifi-qcom capsman setup and I did not notice any issues.
I haven't been able to use this integration since upgrading to ros 7 even without capsman so I am very eager to see this merged.

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Oct 27, 2024
@mvn23
Copy link
Author

mvn23 commented Oct 27, 2024

@tomaae any chance for a review?

@github-actions github-actions bot removed the stale label Oct 28, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Nov 12, 2024
@mvn23
Copy link
Author

mvn23 commented Nov 12, 2024

Still hoping...

@github-actions github-actions bot removed the stale label Nov 13, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Nov 27, 2024
@SkeLLLa
Copy link

SkeLLLa commented Nov 28, 2024

not stale

@brezuicabogdan
Copy link

Definitely not stale - still waiting for this merge!

@github-actions github-actions bot removed the stale label Nov 29, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Dec 13, 2024
@brezuicabogdan
Copy link

Is this going to be merged or not? Should still wait?

@github-actions github-actions bot removed the stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants