-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wifi support for ROS 7.13+ devices without a physical wifi radio #378
base: master
Are you sure you want to change the base?
Conversation
…running routeros 7.13+
I have been testing this branch for the last 24 hours on ROS 7.16and wifi-qcom capsman setup and I did not notice any issues. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@tomaae any chance for a review? |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still hoping... |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
not stale |
Definitely not stale - still waiting for this merge! |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Is this going to be merged or not? Should still wait? |
Proposed change
My CCR2004 has no physical wifi radio, but can manage CAPs through the
wifi
menu.Since ROS 7.13, this is no longer a separate package (only
routeros
is listed under packages).With this PR, we add support for this scenario by disabling capsman and setting the
_wifimodule
towifi
if we're running on ROS 7.13 or later.Type of change
Additional information
Note: The code was not formatted with
black
as that would have resulted in a lot of unrelated changes.Checklist